Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelconsumer] Add log record attributes as flattened keys #42707

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

khushijain21
Copy link
Contributor

Proposed commit message

The log record attributes added on otelconsumer should be flattened keys (and not nested map structure) for dynamic indexing on ES exporter to work correctly. This is a fix for it

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@khushijain21 khushijain21 requested a review from a team as a code owner February 14, 2025 06:21
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 14, 2025
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 14, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 14, 2025
@khushijain21 khushijain21 added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 14, 2025
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left a small suggestion

@khushijain21
Copy link
Contributor Author

/test

@khushijain21
Copy link
Contributor Author

khushijain21 commented Feb 14, 2025

make -C libbeat check update
Installing mage v1.13.0.
/Users/khushijain/.magefile cleaned
>> fmt - go-licenser: Checking for missing headers
>> fmt - go-licenser: Adding missing headers
>> fmt - goimports: Formatting Go code
>> fmt - autopep8: Formatting Python code
>> check: Checking source code for common problems
Generated fields.yml for libbeat to /Users/khushijain/Documents/beats/libbeat/fields.yml
>> Building libbeat.yml for linux/amd64
>> Building libbeat.reference.yml for linux/amd64
Updating generated files for libbeat
if [ -d /Users/khushijain/Documents/beats/libbeat/_meta/kibana ]; then \
                cp -pr /Users/khushijain/Documents/beats/libbeat/_meta/kibana/* /Users/khushijain/Documents/beats/libbeat/_meta/kibana.generated ; \
        fi

is successful locally

@mauri870
Copy link
Member

mauri870 commented Feb 14, 2025

Sorry, edited you comment by mistake thinking I was replying.

is successful locally

It succeeds for me as well. Try and change the command on CI to run with the verbose flag (-v). You should be able to see the offending change once the job fails. Job is in pipeline.libbeat.yml.

@mauri870
Copy link
Member

@khushijain21 I think your failure is related with the conflict, there was another PR that changed the same file, this is likely the cause of the failure you reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otelconsumer] Set data_stream.dataset & data_stream.namespace attributes to support dynamic index
4 participants