Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testify and fix filebeat tests #42747

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Update testify and fix filebeat tests #42747

merged 6 commits into from
Feb 19, 2025

Conversation

haesbaert
Copy link
Contributor

@haesbaert haesbaert commented Feb 18, 2025

Proposed commit message

Testify 1.10 fixed NotSame which exposes a bug in our filebeat tests: stretchr/testify@118fb83

Remove the structure comparison, as they will never be the same address. Require that the maps they hold have a different backing.

Checklist

  • My code follows the style guidelines of this project
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

stretchr/testify@118fb83
#34870 (comment)
#42032 (comment)

Testify 1.10 fixed NotSame which exposes a bug in our filebeat tests:
stretchr/testify@118fb83

Remove the structure comparison, as they will never be the same address.
Require that the maps they hold have a different backing.
@haesbaert haesbaert added the bug label Feb 18, 2025
@haesbaert haesbaert requested review from a team as code owners February 18, 2025 12:12
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 18, 2025
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @haesbaert? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 18, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 18, 2025
@haesbaert haesbaert merged commit 3ff1931 into main Feb 19, 2025
143 checks passed
@haesbaert haesbaert deleted the update-testify branch February 19, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants