[windows] add PDH helpers #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
requested review from
faec and
leehinman
and removed request for
a team
leehinman
reviewed
Nov 11, 2024
i've included them now. We should include these we'll eventually remove the ones in |
leehinman
approved these changes
Nov 11, 2024
VihasMakwana
force-pushed
the
pdh-windows-helpers
branch
2 times, most recently
from
1457347 to
b40e55d
Compare
VihasMakwana
force-pushed
the
pdh-windows-helpers
branch
from
b40e55d to
b2747fd
Compare
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDH (Performance Data Helper) is a high-level API for collecting performance counters.
They're already used in metricbeat. See here.
We also need the PDH helpers in
elastic-system-metricsfor collecting CPU metrics for this issue.This PR introduces them to
elastic-agent-libsand we will eventually remove them frombeats.Related elastic/beats#40926