Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastic-Agent event log documentation #1053

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Apr 26, 2024

This PR adds documentation for the feature introduced by elastic/elastic-agent#4549

@belimawr belimawr requested a review from a team as a code owner April 26, 2024 20:21
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 26, 2024

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

kilfoyle
kilfoyle previously approved these changes Apr 29, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @belimawr!

@belimawr
Copy link
Contributor Author

I'll wait until elastic/elastic-agent#4549 is merged to merge this PR.

@belimawr belimawr changed the title Add new Elastic-Agent diagnostics CLI flag Add Elastic-Agent event log documentation Jun 7, 2024
@belimawr belimawr force-pushed the elastic-agent-event-logs branch from e9ef213 to 65f27f7 Compare June 7, 2024 15:11
@belimawr belimawr requested a review from kilfoyle June 7, 2024 15:12
kilfoyle
kilfoyle previously approved these changes Jun 7, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this @belimawr!

By the way, kind of related to logging, if you have a chance I'd appreciate a review of this PR. It's kind of old now. Sorry I lost track of it. :-)

@belimawr
Copy link
Contributor Author

belimawr commented Jun 7, 2024

By the way, kind of related to logging, if you have a chance I'd appreciate a review of this PR. It's kind of old now. Sorry I lost track of it. :-)

Approved!

@jlind23
Copy link
Contributor

jlind23 commented Jun 10, 2024

@belimawr can we get this merged? :-)

@belimawr
Copy link
Contributor Author

I'm waiting for the PR with the feature elastic/elastic-agent#4549, to be merged before merging this one.

@jlind23
Copy link
Contributor

jlind23 commented Jun 12, 2024

elastic/elastic-agent#4549 has been merged hence merging this one.

@jlind23 jlind23 merged commit 523f22b into elastic:main Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants