-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Tests to Schulze Functions in Core Package. #103
base: main
Are you sure you want to change the base?
Conversation
Why Pandas? Asking because that imports a LOT of modules. |
Otherwise, this looks great, lemme try it out. |
It's was already being used within In all honesty it probably wouldn't be too difficult to remove the need for the dependency entirely. I'm pretty sure the only thing that needs it is |
@CheatCodeSam sorry for delay here, as expected your adding these tests exposed some unrelated problems that prevent testing the PR, specifically;
I'll work on these starting with (2), of course your ideas welcome. |
Awesome, thank you for getting back to me on that. I've been poking around a few of the internals some more and I might have found some stuff that we could leverage for that first one. I'll append it to the PR and keep you in the loop. |
Added a few starter unit test for the Schulze functions.
I added an init file in the test folder so it would be easier to import the elekto module.
I added pytests and pandas into the requirements.txt so that they would be installed with pip install.
I gave the Schulze functions type hints so they're a little easier to work around with, and write tests around.
Let me know if this was what you were looking for, I'm happy to keep testing the other modules of this application.