Created test for dashboard. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, merging. Please pull a change from Main, though; I fixed the Raise statement in config.py. |
|
Also: maybe we should supply an .env.testing? I don't see any good reason to have that be user-generated. |
|
That would def be the highest-priority one. The problem is that we need to test almost every path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few changes here. I got the tests to spawn an sqlite database and test against that. Depending on if the app is running in pytest or not, it's going to use .env or .env.testing. So we can run test in one database and dev/prod in another. I've also added pytest-mock so we can snub out some of the repository checks.
The each individual test is automatically going to migrate the database on startup and drop it on shutdown. I've been running it against "testing.db" and I haven't had any issues with it.
I think this is a good place to go to start really testing this thing. I'd rather not mock out as much as we can.