Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified min passcode length to admin configurable value #58

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

007vedant
Copy link
Collaborator

  • added env variable MIN_PASSCODE_LENGTH in .env.example (to be set by admin in .env)
  • added config variable for MIN_PASSCODE_LENGTH (default value = 6)
  • added decorator for performing passcode length check
  • decorated elections_voting_page()

jberkus and others added 2 commits April 19, 2022 10:37
Added system generated 32 byte secret key for session cookie encryption
- added env variable MIN_PASSCODE_LENGTH in .env.example (to be set by admin in .env)
- added config variable for MIN_PASSCODE_LENGTH (default value = 6)
- added decorator for performing passcode length check
- decorated elections_voting_page()
@007vedant 007vedant requested review from kalkayan and jberkus April 21, 2022 18:28
Copy link
Member

@kalkayan kalkayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jberkus jberkus merged commit a4a6371 into elekto-io:newballot Apr 22, 2022
@jberkus
Copy link
Member

jberkus commented Apr 29, 2022

Tested.

Works as advertised.

Two changes:

  1. Add text to the description text of the passphrase box that gives the min length
  2. move MIN_PASSCODE_LENGTH to end of first group of variables in .env.example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants