Scope requests to view and edit vote record to the specified election #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction The controllers to view and to edit a voter's submission in an election now search for that vote record within the scope of the ID of the election. Otherwise, the controller will find the first vote that user submitted for any election in the system and attempt to decrypt that vote using the supplied password.
|
@jberkus any chance you could review this PR at some point? Thanks! |
|
Thanks. Code looks fine, lemme get it on my test cluster so that I can try it out. |
|
Tested finally. We really need automated tests for "view ballot", sorry. Merging, thanks so much for the patch. New release coming shortly. |
|
Thanks again, @jberkus! |
|
Thank you! And if you know anyone who would like to be a co-maintainer on Elekto, send them my way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controllers to view and to edit a voter's submission in an election now search for that vote record within the scope of the ID of the election.
Otherwise, the controller will find the first vote that user submitted for any election in the system and attempt to decrypt that vote using the supplied password.
This issue arose as the Cloud Foundry community started conducting this year's Technical Oversight Committee election with our Elekto deployment that still had records from the 2022 election. I cast my own vote only to find that the only vote record I could retrieve was my vote from that previous election, with the password I had set for it at the time of submission.