Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Android tokens alphabetically in the output files #125

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

jmartinesp
Copy link
Member

This was disabled for some reason (AKA: because I didn't know what I was doing while building the new templates 😅 ) and makes it harder to do proper diffing on the Compound Android library.

@jmartinesp jmartinesp requested a review from a team as a code owner November 18, 2024 12:26
@jmartinesp jmartinesp requested review from bmarty and removed request for a team November 18, 2024 12:26
@jmartinesp jmartinesp force-pushed the fix/sort-android-tokens-alphabetically-in-outputs branch from 23dd2ba to 85ab1f4 Compare November 19, 2024 15:19
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Edit: Well apart from whatever the linter is upset about 😅

@jmartinesp jmartinesp force-pushed the fix/sort-android-tokens-alphabetically-in-outputs branch from 85ab1f4 to b2d3eb6 Compare November 19, 2024 15:32
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jmartinesp jmartinesp force-pushed the fix/sort-android-tokens-alphabetically-in-outputs branch from b2d3eb6 to 5b25723 Compare November 19, 2024 15:37
@jmartinesp jmartinesp merged commit 04dc58a into main Nov 19, 2024
3 checks passed
@jmartinesp jmartinesp deleted the fix/sort-android-tokens-alphabetically-in-outputs branch November 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants