Add radio menu item #320
Open
Add radio menu item #320
+194
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
requested review from
dbkr and
t3chguy
and removed request for
a team
|
@florianduros any idea why there is no cloudflare preview? |
|
Hmm strange, I'll rebase on main to see if it's triggering a preview |
florianduros
force-pushed
the
florianduros/radio-menu-item
branch
from
cc1ee91 to
fefad03
Compare
Deploying compound-web with
|
| Latest commit: |
fefad03
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7889a80a.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-radio-menu-item.compound-web.pages.dev |
florianduros
commented
Feb 26, 2025
|
|
||
| type Props = Omit< | ||
| React.ComponentProps<typeof RadioMenuItemComponent>, | ||
| "Icon" | "label" | "checked" | "onSelect" | "name" |
|
This looks to not follow best wai-aria practices where arrow keys do not change the radio selection, only space/enter does https://ariakit.org/examples/menu-item-radio - this may just be a symptom of the Story. Could you update the story to match the best practice so that we can confirm the component can be used to achieve this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radio menu item in figma
Implementation close to the
CheckboxMenuItem