Don't mark room as unread due to reactions #5846
Conversation
| @@ -103,12 +100,6 @@ class DisplayableEventFormatter @Inject constructor( | |||
| EventType.STICKER -> { | |||
| simpleFormat(senderName, stringProvider.getString(R.string.send_a_sticker), appendAuthor) | |||
| } | |||
| EventType.REACTION -> { | |||
There was a problem hiding this comment.
This seems to be unused after my changes.
| @@ -214,11 +205,6 @@ class DisplayableEventFormatter @Inject constructor( | |||
| EventType.STICKER -> { | |||
| stringProvider.getString(R.string.send_a_sticker) | |||
| } | |||
| EventType.REACTION -> { | |||
There was a problem hiding this comment.
This is the formatThreadSummary() pair of the above deletion, I deleted it for consistency. But let me know if this is a bad idea.
ouchadam
added
X-Needs-Product
|
looping in product to confirm the behaviour
|
|
Just a friendly ping to make sure it's not forgotten. If it's okay from the product POV, I'll rebase this PR and resolve conflicts. |
|
🎙 Product The Web product has a setting that changes whether the reaction shows up in the message preview - is that something we have here? Otherwise, looks good. Glad that we're matching Web! |
|
@daniellekirkwood this change simply disables the unread reactions (as shown on the screenshots). But if you say a new setting is required for this, I'm happy to include that. Just to clarify: in the web product this is under Labs and it's disabled by default (meaning that this PR will change the default behavior). |
|
Good to know, thanks! |
| @@ -32,6 +32,5 @@ object RoomSummaryConstants { | |||
| EventType.CALL_ANSWER, | |||
| EventType.ENCRYPTED, | |||
| EventType.STICKER, | |||
| EventType.REACTION | |||
There was a problem hiding this comment.
I would merge this PR if this was the only change (with the changelog). Let's do not touch DisplayableEventFormatter.kt and strings.xml, just in case this is added again (in the project or in a fork).
|
@ofalvai can I ask you to handle #5846 (comment)? Then we could merge this PR. Thanks! |
|
|
Type of change
Content
Fixes #2907
Motivation and context
I found it distracting and frustrating that my room list had a lot of unread indicators, showing unread reactions by other people. This is especially distracting in read-only announcement rooms where reactions are often added to old messages.
This change also aligns Element Android to Element Web in handling reactions.
Screenshots / GIFs
Tests
Manual testing with my own unread channels
Tested devices
Checklist
Signed-off-by: Olivér Falvai [email protected]