Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user verification #4294

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

jmartinesp
Copy link
Member

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Copy link
Contributor

github-actions bot commented Feb 21, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/c4G8Mw

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 84.58244% with 72 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (86afffb) to head (680f231).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
...mpl/verification/RustSessionVerificationService.kt 0.00% 13 Missing ⚠️
...d/libraries/designsystem/utils/OpenUrlInTabView.kt 0.00% 9 Missing ⚠️
.../verification/SessionVerificationRequestDetails.kt 0.00% 9 Missing ⚠️
...droid/libraries/designsystem/components/BigIcon.kt 85.00% 0 Missing and 6 partials ⚠️
...ion/impl/incoming/IncomingVerificationPresenter.kt 80.76% 1 Missing and 4 partials ⚠️
...rifysession/impl/outgoing/VerifySelfSessionView.kt 91.66% 0 Missing and 4 partials ⚠️
...ies/matrix/api/verification/VerificationRequest.kt 50.00% 4 Missing ⚠️
...tures/verifysession/api/VerifySessionEntryPoint.kt 0.00% 3 Missing ⚠️
.../impl/incoming/IncomingVerificationStateMachine.kt 75.00% 3 Missing ⚠️
...ion/impl/outgoing/VerifySelfSessionStateMachine.kt 88.00% 2 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4294      +/-   ##
===========================================
- Coverage    80.13%   80.11%   -0.02%     
===========================================
  Files         2052     2058       +6     
  Lines        54576    54736     +160     
  Branches      6672     6699      +27     
===========================================
+ Hits         43733    43851     +118     
- Misses        8560     8598      +38     
- Partials      2283     2287       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants