Skip to content

Commit

Permalink
Tweaks to TODO, README and some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
eliben committed Jul 15, 2020
1 parent 24196c2 commit 9fffee2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Bundling for the browser

We use `browserify`; see `Makefile` for the invocation.
js-8080-sim uses `browserify`; see `Makefile` for the invocation.

The files `index.html`, `ui.js` and `js8080simBundle.js` should be distributed
together to make it all work in the browser.
7 changes: 0 additions & 7 deletions TODO
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
* Show assembled labels?

* CPU8080 has global state, which sucks. Refactor it, but after I have it
working to avoid distraction.

* Create a UI similar to https://schweigi.github.io/assembler-simulator/

Links:

* Instruction encoding: http://www.classiccmp.org/dunfield/r/8080.txt
Expand Down
4 changes: 3 additions & 1 deletion test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ const CPU8080 = require('../src/sim8080');
// [cpu state, memory map] after the program halts.
// If maxSteps is provided, runs up to maxSteps steps (otherwise a default upper
// limit is applied to avoid hanging).
// TODO: it sucks that CPU8080 manipulates global state; fix it.
//
// Note: CPU8080 uses global state. It's important to call init() every time
// we start a new simulation. Multiple simulations cannot run concurrently.
function runProg(progText, maxSteps) {
let p = new Parser();
let asm = new Assembler();
Expand Down

0 comments on commit 9fffee2

Please sign in to comment.