Support basic current line highlighting #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks interesting. Please let me know when you think this PR is ready for review. |
|
I guess we can live with the issue when entering on the highlighted line... |
|
I somehow fixed the enter issue, far from perfect though... |
|
Just a quick note that I don't plan to review/merge this any time soon. This is a rather complicated change, and I don't have the capacity to review it now. Folks interested in using this can easily apply this PR onto their clone (or check it out directly). I may get back to this in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo was exactly what I was looking for to get some quick hands-on with 8080 processor while reading the awesome book "Code: The Hidden Language of Computer Hardware and Software, 2nd Edition". Thanks a lot!
I started to implement highlighting of executed instruction, would also be nice to extend this to highlight changes in the register and memory view.
It seems to work, the only issue I could find is when "entering" on an highlighted line the caret positioning is messed up...