Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NavBottom fixed, not sticky #2475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zmc
Copy link

@zmc zmc commented Nov 17, 2023

I could be missing something, but this fixes the bottom nav bar for me on mobile in Firefox, doesn't regress in Chrome, and doesn't affect the desktop layout.

resolve #1558

I could be missing something, but this fixes the bottom nav bar for me on mobile in Firefox, doesn't regress in Chrome, and doesn't affect the desktop layout.

resolve elk-zone#1558
Copy link

stackblitz bot commented Nov 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit a3d1f0f
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6556ff546f33c700081281a8

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit a3d1f0f
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6556ff54ce81270008a8be5e
😎 Deploy Preview https://deploy-preview-2475--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev
Copy link
Member

We tried this already and we needed to revert it, see:

It seems we need something else to avoid the regression

@zmc
Copy link
Author

zmc commented Nov 17, 2023

We tried this already and we needed to revert it, see:

* [fix: mobile header and footer prevent flicker on ios safari #660](https://github.com/elk-zone/elk/pull/660)

* [fix: Position NavBottom with "fixed" instead of "sticky" #2252](https://github.com/elk-zone/elk/pull/2252)

It seems we need something else to avoid the regression

I see. Could you elaborate a bit on why it had to be reverted? I can only find the phrase "some issues with Android".

@patak-dev
Copy link
Member

I dont recall, I think there was flickering

@zmc
Copy link
Author

zmc commented Nov 20, 2023

Is it possible the flickering was caused by something else? I have seen none with this branch on my Pixel 6.

@edimitchel
Copy link
Collaborator

We should try this on safari, and ensure we don't have problem with the content which became hidden by the header.
See on the closed pr mentioned the behavior to avoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android firefox touch is offset by size of address bar
3 participants