-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NavBottom fixed, not sticky #2475
base: main
Are you sure you want to change the base?
Conversation
I could be missing something, but this fixes the bottom nav bar for me on mobile in Firefox, doesn't regress in Chrome, and doesn't affect the desktop layout. resolve elk-zone#1558
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We tried this already and we needed to revert it, see:
It seems we need something else to avoid the regression |
I see. Could you elaborate a bit on why it had to be reverted? I can only find the phrase "some issues with Android". |
I dont recall, I think there was flickering |
Is it possible the flickering was caused by something else? I have seen none with this branch on my Pixel 6. |
We should try this on safari, and ensure we don't have problem with the content which became hidden by the header. |
I could be missing something, but this fixes the bottom nav bar for me on mobile in Firefox, doesn't regress in Chrome, and doesn't affect the desktop layout.
resolve #1558