-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): settings items without href #2767
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is actually the correct behavior in browsers:
So maybe setting I also noticed that some |
The html markup is wrong, we're using an anchor when it is a button, check other pages, we dont use anchor for render theme color buttons |
Any anchor without href cannot be traversed with the keyboard.
This PR uses custom nuxt link and vue component for button when
button
attr configured: theShow intro
"link" cannot be activated using the keyboard (maybe there is a shorcut)