Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve return type of getPageTitle test helper #288

Conversation

bertdeblock
Copy link
Contributor

No description provided.

@@ -1,17 +1,17 @@
// Testem appends progress to the title...
// and there's no way to stop this at the moment

export function getPageTitle(doc: Document) {
export function getPageTitle(doc?: Document): string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc should not be required because of doc || window.document.

Copy link
Contributor Author

@bertdeblock bertdeblock Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current return type is string | false | undefined because of the current implementation. Using string and updating the implementation seems better. Technically, a breaking change though.

element instanceof HTMLTitleElement &&
element.innerText.trim().replace(/^\(\d+\/\d+\)/, '')
);
if (element instanceof HTMLTitleElement) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much easier to read, thank you!

@NullVoxPopuli NullVoxPopuli merged commit bd273e7 into ember-cli:master Feb 15, 2024
21 checks passed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants