Cleanup legacy code #1519
Open
Cleanup legacy code #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was deprecated and removed in 4.0, which is now the minimum supported version.
chancancode
force-pushed
the
cleanup-legacy-rebased
branch
2 times, most recently
from
474e4d1 to
33657d7
Compare
Turns out that accounts for _all_ of the current usage.
chancancode
force-pushed
the
cleanup-legacy-rebased
branch
from
33657d7 to
fd10660
Compare
chancancode
commented
Nov 22, 2024
| router = mainRouter as Router; | ||
| ROUTER.set(context, router); | ||
| } | ||
|
|
chancancode
commented
Nov 22, 2024
| // sub-classed. The most we can do at present is assert that it at least | ||
| // *exists* and assume that if it does exist, it is bound correctly. | ||
| const router = owner.lookup('service:router') as RouterService; | ||
| assert('router service is not set up correctly', !!router); |
There was a problem hiding this comment.
..and this hunk, should be the only non-trivial modification (even then this is still pretty trivial, just following the lead of the linter and consolidated some variables)
|
any chance you'd be willing to rebase? <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the branching needed for less than supported versions (<4) of Ember. Turns out that is everything at this point.
I did not very carefully examine what each branch is doing, but just mechanically evaluated each conditional and deleted the logically dead branch.