-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework validation for measurements
and pending_experiments
#456
Open
Scienfitz
wants to merge
11
commits into
main
Choose a base branch
from
feature/exp_input_validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+318
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianSosic
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Scienfitz, thanks the refactor 🏗️ Below my comments
Scienfitz
force-pushed
the
feature/exp_input_validation
branch
3 times, most recently
from
January 6, 2025 12:36
0a42492
to
a412305
Compare
AVHopp
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: AdrianSosic <[email protected]>
Scienfitz
force-pushed
the
feature/exp_input_validation
branch
from
January 14, 2025 13:20
7056db6
to
969dea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
Notes re
measurements
validationadd_measurements
andfuzzy_row_match
fuzzy_row_match
does not perform any validation anymoreadd_measurements
now simply calls the utilitiesNotes re
pending_experiments
validationpending_experiments
has been addedRemaining problem:
The places of validation for
measurements
andpending_experiments
are inconsistent. The former is done in the campaign and not in any recommender, the latter is not done in the campaign but done in the recommender. One of the issues is thatnumerical_measurements_must_be_within_tolerance
is not available for recommenders, but its required for the parameter input validation.Suggestion:
Imo we dont want to add more keywords to
.recommend
or so, hence thepending_experiments
validation currently assumesnumerical_measurements_must_be_within_tolerance=False
and cannot be configured otherwise. To me it seems the simplest solution would be to completely get rid of anynumerical_measurements_must_be_within_tolerance
keywords and make it an environment variable, we wouldn't have to worry about its availability anymore and it would require adding it to more and more signatures.