Tweak HTML/XML related selectors in settings #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit common indentation style to all settings. According to .editorconfig `tabs` seem preferred indentation.
Fixes emmetio#188 Ensure to detect embedded HTML code, but exclude embedded source in HTML. This commit enables Emmet in e.g. Astro templates of scope: `source.astro text.html.astro`. It however disables it within embedded sources of scope `text.html source`. related with SublimeText/Astro#10
Fixes emmetio#184 Fixes Sublime-Instincts/BetterTwig#40 This commit fixes abbreviations being disabled in various template syntaxes such as Jinja2 or Twig, which use common `text.html meta.template` scope to enable template related snippets and completions in all sub-syntaxes with easy/short selectors. Instead of excluding all meta scopes by `- meta`, only relevant ones are, which indicate embedded or interpolated templating code or html tags. `text.html.cfml - meta.tag` is removed as it is coverd by `text.html - text.html meta.tag`. Note each negative selector is prefixed with `text.html` to make sure to match only parts within HTML/XML, even if it is embedded in another source code. That's required to keep abbreviations working in e.g. `source.astro text.html`.
|
Thanks, published as 2.4.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Fixes #188
This PR proposes to modify html/xml related selectors to properly enable Emmet, if HTML is embedded into source or used in template syntaxes such as Astro, Jinja2, Svelte or Twig.