fix(hocon_pp): ensure the pretty-print result is a list of lines #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
previously approved these changes
Feb 14, 2024
It is technically possible to format oneliner triple quotes, but it would require escaping the linebreaks, making it pointless to use triple quotes.
zmstone
force-pushed
the
0214-fix-pp-api-contract
branch
from
a7079c2 to
d8c3ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
,between 'oneliner' struct fields and array elements.hocon_pp:dofunction returns a list ofbinary()strings, one for each line -- some callers rely on this contract.