Skip to content

Commit

Permalink
[cli] Skip export with bad time stamp (#2702)
Browse files Browse the repository at this point in the history
## Description

## Tests
  • Loading branch information
ua741 authored Aug 14, 2024
2 parents fda7722 + 39e505a commit 37dec00
Show file tree
Hide file tree
Showing 21 changed files with 32 additions and 20 deletions.
2 changes: 1 addition & 1 deletion cli/docs/generated/ente.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_account.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_account_add.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_account_get-token.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_account_list.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_account_update.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_delete-user.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_disable-2fa.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_disable-passkey.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_get-user-id.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_list-users.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_admin_update-subscription.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_auth.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_auth_decrypt.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions cli/docs/generated/ente_export.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/docs/generated/ente_version.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"strings"
)

var AppVersion = "0.1.17"
var AppVersion = "0.1.18"

func main() {
cliDBPath, err := GetCLIConfigPath()
Expand Down
4 changes: 4 additions & 0 deletions cli/pkg/model/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ func ShouldRetrySync(err error) bool {
return strings.Contains(err.Error(), "read tcp") ||
strings.Contains(err.Error(), "dial tcp")
}

func IsBadTimeStampError(err error) bool {
return strings.Contains(err.Error(), "year outside of range ")
}
2 changes: 1 addition & 1 deletion cli/pkg/model/remote.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (r *RemoteFile) GetCreationTime() time.Time {
func (r *RemoteFile) GetModificationTime() time.Time {
value, ok := r.Metadata["modificationTime"]
if !ok {
panic("creationTime not found in metadata")
panic("modificationTime not found in metadata")
}
return time.UnixMicro(int64(value.(float64)))
}
Expand Down
4 changes: 4 additions & 0 deletions cli/pkg/remote_to_disk_file.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ func (c *ClICtrl) syncFiles(ctx context.Context, account model.Account) error {
continue
} else if existingEntry.IsLivePhoto() && errors.Is(err, model.ErrLiveZip) {
continue
} else if model.IsBadTimeStampError(err) {
log.Printf("Skipping file due to error %s (%d)", existingEntry.GetTitle(), existingEntry.ID)
log.Printf("CreationTime %v, ModidicationTime %v", existingEntry.GetCreationTime(), existingEntry.GetModificationTime())
continue
} else {
return err
}
Expand Down

0 comments on commit 37dec00

Please sign in to comment.