Fix type annotations for idlflags
and _dispimpl_
.
#817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The originator of this project left the following comment:
comtypes/comtypes/client/_events.py
Line 258 in 44aafcb
As seen in the refactored current codebase,
dispid
is only assigned at index 0 ofidlflags
.ComMethodGenerator
comtypes/comtypes/tools/codegenerator/helpers.py
Lines 117 to 127 in 01b6fc0
DispMethodGenerator
comtypes/comtypes/tools/codegenerator/helpers.py
Lines 224 to 231 in 01b6fc0
If there is a case where this is not true (i.e., where the newly added
assert isinstance(dispid, comtypes.dispid)
fails), it would be an undiscovered bug.