Fix integrity config example in README #664
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking for a way to prevent
<img>
elements from having anintegrity
attribute because that's not valid HTML. I saw this config snippet in the README:I tried it out, but I got an exception (
undefined method 'key?' for "highlighter":String
). After reading the source code I found this hint:jekyll-assets/lib/jekyll/assets/plugins/html/defaults/img.rb
Lines 59 to 68 in 056d2c8
It drove me to realize that this config will do what I want:
Additionally, the README says that "All values listed below are default", which made me unsure if the values should be set to
true
orfalse
because the real default value isJekyll.production?
. I chosetrue
because I consider it's more important to know what happens in production, but let me know if you disagree. Maybe a comment would be necessary?