Issue 815 batch restore of objects for GCP #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StackOF problem - need to fix!
…ests for restoreFolder GCP method helper.
ekazachkova
requested changes
Dec 4, 2019
| } | ||
| }; | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| private boolean isFileWithDeleteMarkerAndShouldBeRestore(final AbstractDataStorageItem item, |
There was a problem hiding this comment.
Maybe we should move this method into ProviderUtils to reuse it into S3Helper ?
| if (StringUtils.isNotBlank(folderPath)) { | ||
| folderPath = normalizeFolderPath(requestPath); | ||
| } | ||
| final Page<Blob> blobs = client.list(bucketName, |
There was a problem hiding this comment.
Maybe it would be better to move this logic into separate method and reuse it into listItems methd?
There was a problem hiding this comment.
Did it, now it looks little bit better
| } | ||
| }; | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| private boolean isFileWithDeleteMarkerAndShouldBeRestore(final AbstractDataStorageItem item, |
There was a problem hiding this comment.
Maybe we should move this method into ProviderUtils class and reuse it into S3Helper?
| if (isFileWithDeleteMarkerAndShouldBeRestore(item, restoreFolderVO)) { | ||
| final Blob blob = checkBlobExistsAndGet(bucketName, item.getPath(), client, | ||
| removeDeletedMarkerFromVersion(((DataStorageFile) item).getVersion())); | ||
| final Storage.CopyRequest request = Storage.CopyRequest.newBuilder() |
There was a problem hiding this comment.
Maybe it would be better to create a new method (wth copy bob logic) and reuse it into restoreFileVersion?
evgeniimv
force-pushed
the
issue_792_batch_restore_s3_GCP
branch
from
e5b8a8e to
2ac0ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR related to issue #815
The same logic as in PR #806 (issue #792)
Description:
Introducing of a new feature in the GCP-CP client for the ability to restore folders in the GCP storage.
Implementing a new RestoreFolderVO object to configure folder restoration.
General options:
Details:
Specifying RestoreFolderVO is mandatory; specifying the include/exclude lists is optional.
Specifying the path to the recovery folder is optional; an empty path means the root directory.