fix: support multiple reserved IP blocks of same type in a metro #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Oct 9, 2024
ctreatma
force-pushed
the
ip_reservation_lookup
branch
from
299cb1b to
0b2aa73
Compare
ctreatma
force-pushed
the
ip_reservation_lookup
branch
from
bf97051 to
a3bc586
Compare
ctreatma
force-pushed
the
ip_reservation_lookup
branch
from
a3bc586 to
4230192
Compare
ctreatma
force-pushed
the
ip_reservation_lookup
branch
from
4230192 to
af3109c
Compare
ctreatma
force-pushed
the
ip_reservation_lookup
branch
from
af3109c to
18cac5b
Compare
cprivitere
force-pushed
the
ip_reservation_lookup
branch
from
18cac5b to
2c578f2
Compare
cprivitere
approved these changes
Oct 17, 2024
|
This PR is included in version 0.11.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
networkattribute, if it is specified in the task config, to differentiate between different IP reservations of the same type in the same metro.Fixes #235