Fix a tail recursion bug #9463
Merged
Fix a tail recursion bug #9463
+393
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 24 suites 6m 56s ⏱️ Results for commit a46f196. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
lthor
force-pushed
the
lars/xmerl/tail-recursion-bug-27/OTP-19496
branch
2 times, most recently
from
9e370aa to
a3c7a0f
Compare
dgud
reviewed
Feb 19, 2025
Comment on lines
+2888
to
+2889
| exit:_ -> | ||
| ?fatal(error_scanning_entity_ref,S) |
There was a problem hiding this comment.
This should be an exit, double checked the code.
dgud
reviewed
Feb 19, 2025
lib/xmerl/src/xmerl_scan.erl
Outdated
| ok | ||
| ok | ||
| catch | ||
| exit:{'EXIT',{cyclic,_}} -> |
There was a problem hiding this comment.
sofs do error not exit
Suggested change
| exit:{'EXIT',{cyclic,_}} -> | |
| error:{'EXIT',{cyclic,_}} -> |
There was a problem hiding this comment.
Fixed, should be: error:{cyclic,_} ->
dgud
previously approved these changes
Feb 19, 2025
- Rewrote some recursion when calling continuation fun in xmerl_sax_parser_base. - Remove all old style catch calls in xmerl
lthor
force-pushed
the
lars/xmerl/tail-recursion-bug-27/OTP-19496
branch
from
a3c7a0f to
a46f196
Compare
dgud
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes xmerl_sax_parser:stream/2 stack keeps growing until the VM is OOM #9190