Merge 1.8.x-beta into master

[xPaw]

The changes are minimal, master already had all the code changes from 1.8 branch, so this simply adds github actions and bumps up the php version.

@erusev mind taking a look so that there's less confusion about master and the 1.8 branch?

[erusev]

@xabbuh do you have any thoughts on this?

[BenjaminHoegh]

I think it would be a good idea as 1.8 seems stable as improve common mark support a lot. It also fixes a lot of issues with GFM. And for extensions there is little to no work for adding support for the changes

[xabbuh]

@erusev sounds reasonable to me

[erusev]

If we merge 1.8.x-beta into master, can we then remove the 1.8.x-beta branch? I find the branch situation a bit confusing.

[xPaw]

I believe it can be removed, yes.

[erusev]

If we merge 1.8.x-beta into master, can we then remove the 1.8.x-beta branch? I find the branch situation a bit confusing.

@xabbuh do you have any thoughts on this?

[aragon999]

One thing, which is changed by this merge in addition to the changes which are in the 1.8.x branch, is that the tests are not compatible with php 7.1 (phpunit version 7.5).

But in my opinion this is fine, as this version is already eol for some time now (December 2019): https://www.php.net/eol.php

Maybe this php version should be dropped as well for the 1.8.0 release.

[xPaw]

PHPUnit 7 specifies PHP 7.1 - PHP 7.3 support, is that not the case?

The github action does have 7.1 in the test matrix, but it didn't run on this PR. Does seem to work here though: https://github.com/xPaw/parsedown/actions/runs/10592900295/job/29353218280

[aragon999]

@xPaw ah yes, sorry for the confusion. I was thinking about it the other way around, i.e. see the following commment:
https://github.com/sebastianbergmann/phpunit/blob/7.5.20/src/Framework/TestCase.php#L407

But if you add the void declaration in the child class, it is fine: https://3v4l.org/tNYS3#v7.1.33

[xabbuh]

This looks reasonable to me. 👍

[erusev]

Should we also release 1.8.0 and make it latest? @aidantwoods @xabbuh @xPaw

[xPaw]

I've been running that code in production for a while.

[erusev]

What should the release notes for 1.8.0 say?

[BenjaminHoegh]

What should the release notes for 1.8.0 say?

Can't you use the one from the draft #601 ?

you could easily make it something like this from that list:

New Features

• AST Production Before Render (Produce AST prior to render #576): Now produces the AST prior to rendering, improving flexibility for advanced processing.
• Optional Element Naming (Allow element to have no name #511): Elements can now be defined without a name, allowing content-only rendering in certain contexts.
• Trusted Raw HTML Option (Add rawHtml option for extensions to use on trusted input #569): Enables extensions to add raw HTML when handling trusted inputs, with safeguards in place to maintain safety.
• Strict Mode Compliance Option (Support #hashtag per CommonMark and GFM specs #589): Adds an opt-in mode for strict CommonMark compliance, helping maintain adherence to specific formatting rules.

Bug Fixes

This release addresses multiple issues, improving parsing accuracy and compliance with CommonMark:

• Email Autolink Fix (Email autolink shouldn't be started by HTML tags #566): Prevents unintended autolink creation triggered by HTML tags.
• HTML Block Treatment Adjustments (Added tests for consistency when a markdown follows a markup without blank line #514): Enhanced handling of HTML blocks, fixing multiple inconsistencies.
• Setext Heading Rendering (Fix setext heading space handling #578): Fixes an issue with rendering headers when trailing spaces are present.
• Improved List Compliance (Improve CommonMark mixed-marker list compliance #439): Achieves mixed-marker list compliance with CommonMark standards.
• Legacy Escaping Removal (Remove legacy escaping #574): Cleans up outdated escaping methods, streamlining the parser’s handling of inline elements.
• Trimming of Internal # in ATX Headers (Fix trimming of internal #'s in ATX headers #583): Fixes trimming behavior to improve ATX header parsing.
• 1-Column Table Support (Permit 1 column tables with less delimiters and assert header count matches delimiters in delimiter row #584, Table header should not be allowed to contain new lines #612): Adds support for tables with single columns and ensures header count aligns with delimiter rows.
• Adjacent Blockquote Merging (Fix merging of adjacent blockquotes #586): Corrects blockquote merging for cleaner markdown output.
• Ordered List Interrupts (Fix ordered list interrupt #587): Fixes issues where ordered lists were interrupted improperly.
• HTML Comment Endings (Fix HTML comment endings #592): Corrects handling of HTML comments.
• Empty ATX Heading Recognition (#772c919): Ensures empty ATX headings are recognized and parsed correctly.
• Code Block Closer Length Rules (Fix fenced code block closer length rules #600): Updates rules for code block closures to prevent parsing errors.
• Preserved Line Breaks (Fix lost line breaks #610): Fixes line break handling to avoid loss of formatting.
• Escape Support for Tilde Characters (Tilde characters may be escaped #621): Adds escape handling for tilde characters, addressing a CommonMark compliance issue.

[dregad]

It's great to see Parsedown getting some attention again, thanks guys.

I'm not sure if you are aware, but a few years ago @aidantwoods posted this: #714 (comment)

I ended up deciding not to release 1.8.x as a minor upgrade due to quite a few internal changes that might break extensions (context: #601 (comment)). If you're not using any extensions then I'd just go ahead and use 1.8.x for now (it contains quite a few bug fixes over 1.7.x).

EDIT: details of the actual breakage are in #601 (comment), not in the post originally referenced in the above quote.

I personally don't use extensions so I'm fine with the potential BC break, but you might want to at least mention that in the 1.8 release notes. Maybe @aidantwoods will care to comment.

[BenjaminHoegh]

It's great to see Parsedown getting some attention again, thanks guys.

I'm not sure if you are aware, but a few years ago @aidantwoods posted this: #714 (comment)

I ended up deciding not to release 1.8.x as a minor upgrade due to quite a few internal changes that might break extensions (context: #601 (comment)). If you're not using any extensions then I'd just go ahead and use 1.8.x for now (it contains quite a few bug fixes over 1.7.x).

EDIT: details of the actual breakage are in #601 (comment), not in the post originally referenced in the above quote.

I personally don't use extensions so I'm fine with the potential BC break, but you might want to at least mention that in the 1.8 release notes. Maybe @aidantwoods will care to comment.

Valid point, maybe we should consider changing the version number to 2.0.0 as this would follow semantic version. Then the current branch for 2.0 would have to change to 3.0

[erusev]

@aidantwoods Would love to get your thoughts on this.

[erusev]

Looks like initially @aidantwoods wanted to release this as 1.8:

On making this a minor release, I think it is certainly "fair game" due to not breaking the public API. -- #601 (comment)

But then he decided against it:

I ended up deciding not to release 1.8.x as a minor upgrade due to quite a few internal changes that might break extensions. -- #714 (comment)

I'm open to releasing it as 2.0, but the fact that @aidantwoods never released it as a stable release makes me wonder if it's good enough.

[joeworkman]

If you want to play it safe, release it as 2.0...

[Evgeny1973]

PHP 8.4 says:

Deprecated: Parsedown::blockSetextHeader(): Implicitly marking parameter $Block as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/erusev/parsedown/Parsedown.php on line 715

Deprecated: Parsedown::blockTable(): Implicitly marking parameter $Block as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/erusev/parsedown/Parsedown.php on line 853

Can you update, pls?

[xabbuh]

@Evgeny1973 with which version of this package do you get it?

[Evgeny1973]

@xabbuh Parsedown 1.7.4 and Symfony 7.1.

[Evgeny1973]

Sorry, as I see fixes of these deprecations to the master branch have already been made. Looking forward to the release!

[dregad]

@xabbuh would it be possible to tag 1.7.5 with this fix ? see #889