Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution source to pip #55

Closed

Conversation

johnnymck
Copy link

@johnnymck johnnymck commented Jul 12, 2020

#32 Adds source distribution to PIP.

Once built; will need to be uploaded to PyPi.

Some edits may be required to setup.py. Feel free to make these changes 😀

(also please ignore the branch name - minor brainfart on my part)

@dmikushin
Copy link

Hi @johnnymck, I've tested your PR on MacOS Catalina 10.15 using a branch link:

pip3 install git+https://github.com/johnnymck/pygmo2.git@add-distrobution-source-to-git

Although the pygmo package formally builds, the native C++ modules ain't getting compiled in:

  File "/Users/marcusmae/hypersolve.io/spyder/venv/lib/python3.7/site-packages/pygmo/__init__.py", line 13, in <module>
    from .core import *
ModuleNotFoundError: No module named 'pygmo.core'

@johnnymck
Copy link
Author

Hiya @dmikushin, is this perhaps due to my lack of ESA's CICD on my repo performing all the build steps perhaps? I'm not certain on why this might happen, but I suspect this may be why.

@dmikushin
Copy link

@johnnymck I'm not sure how CICD is getting into play here. I think it's rather about the actual content of setup.py. As long as they have C++ sources, their compilation must be explicitly handled within setup.py, as shown e.g. here.

@johnnymck
Copy link
Author

Aye it would seem that you're correct. 👍

My C++ is a tad rusty - what are the usual compilation steps, and which is the main file in the pygmo cpp library, so I know how to include the compilation steps?

@dmikushin
Copy link

dmikushin commented Aug 7, 2020

@johnnymck If you are on Linux/Mac, please test #56 :

pip3 install git+https://github.com/apc-llc/pygmo2.git

Builders are yet to be fixed.

@darioizzo
Copy link
Member

Closing this. Thank for the attempt, but we cannot add the source using this method as the library compiled from c++ is architecture dependent. A wheel must be compiled for each platform and uploaded. For all linux the manylinux project provides this and is now active again via #117

@darioizzo darioizzo closed this Jan 16, 2023
@johnnymck johnnymck deleted the add-distrobution-source-to-git branch July 30, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants