Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-callback-in-promise): false positives when the exception is an argument #446

Merged
merged 1 commit into from
May 27, 2024

Conversation

ahce
Copy link
Contributor

@ahce ahce commented Aug 26, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make?

Fixes false positives when the exception is an argument of the promise call expression.

image

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (79d8d0d).
Report is 7 commits behind head on main.

Current head 79d8d0d differs from pull request most recent head 98cf8d9

Please upload reports for the commit 98cf8d9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          649       646    -3     
  Branches       250       246    -4     
=========================================
- Hits           649       646    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey requested a review from a team August 27, 2023 14:24
@ahce
Copy link
Contributor Author

ahce commented Oct 16, 2023

@MichaelDeBoey any chance to merge this? 🙏

@aladdin-add aladdin-add merged commit 5e4546d into eslint-community:main May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants