Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use flat config for eslint #201

Merged
merged 4 commits into from
Mar 30, 2024
Merged

refactor: use flat config for eslint #201

merged 4 commits into from
Mar 30, 2024

Conversation

kecrily
Copy link
Member

@kecrily kecrily commented Dec 16, 2023

  • Update ESLint-related dependencies and add globals
  • Refactor to flat config

nzakas
nzakas reviewed Dec 21, 2023
View reviewed changes
eslint.config.js Outdated Show resolved Hide resolved
src/plugins/release-monitor/index.js Outdated Show resolved Hide resolved
@kecrily kecrily mentioned this pull request Dec 22, 2023
Merged
1 task
@kecrily
Copy link
Member Author

kecrily commented Jan 26, 2024

Wait for eslint-config-eslint to release a new version.

@mdjermanovic
Copy link
Member

Wait for eslint-config-eslint to release a new version.

For eslint/eslint#17900? If that is a blocker, we can configure the rule in this project's eslint.config.js until the new version is released.

@kecrily
Copy link
Member Author

kecrily commented Jan 28, 2024

I think it's OK.

mdjermanovic
mdjermanovic reviewed Feb 4, 2024
View reviewed changes
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
@kecrily @mdjermanovic
Apply suggestions from code review
640366d 
Co-authored-by: Milos Djermanovic <[email protected]>
@mdjermanovic
Copy link
Member

We can also remove tests/.eslintrc.js file.

@aladdin-add
Copy link
Member

friendly ping @kecrily

@kecrily @mdjermanovic
Update eslint.config.js
c7184d3 
Co-authored-by: Milos Djermanovic <[email protected]>
@kecrily
Copy link
Member Author

kecrily commented Mar 29, 2024

Sorry for not noticing this.

aladdin-add
aladdin-add approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like @mdjermanovic to re-review before merging.

mdjermanovic
mdjermanovic approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 1030daf into eslint:main Mar 30, 2024
5 checks passed
aladdin-add added a commit that referenced this pull request May 21, 2024
@aladdin-add
Revert "refactor: use flat config for eslint (#201)"
d9f5ac9 
This reverts commit 1030daf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas left review comments

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
chore
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kecrily @mdjermanovic @aladdin-add @nzakas