Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: auto update sponsors in README #613

Merged
merged 2 commits into from
Jul 22, 2024
Merged

ci: auto update sponsors in README #613

merged 2 commits into from
Jul 22, 2024

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jul 19, 2024 •
edited
Loading

Cron job to update sponsors in README.

We need to enable the secrets.WORKFLOW_PUSH_BOT_TOKEN secret for this repo. Can someone with access do it?

@snitin315 snitin315 marked this pull request as ready for review July 19, 2024 06:11
@snitin315
Copy link
Contributor Author

npm install step is failing for node v22, looking into it.

@fasttime
Copy link
Member

npm install step is failing for node v22, looking into it.

I think this is the same problem as in eslint CI, it's a bug in Node.js v.22.5.0.

@snitin315
Copy link
Contributor Author

npm install step is failing for node v22, looking into it.

I think this is the same problem as in eslint CI, it's a bug in Node.js v.22.5.0.

Should we pin node.js version to v22.4.0?

@mdjermanovic
Copy link
Member

Node.js v22.5.1 has been released:

https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#2024-07-19-version-2251-current-richardlau

Waiting for actions/setup-node#1112

@mdjermanovic
Copy link
Member

We need to enable the secrets.WORKFLOW_PUSH_BOT_TOKEN secret for this repo

I've enabled it now.

mdjermanovic
mdjermanovic approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just waiting for the CI fix.

fasttime
fasttime approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 47b40c2 into main Jul 22, 2024
11 checks passed
@fasttime fasttime deleted the ci-readme-update branch July 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
build
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snitin315 @fasttime @mdjermanovic