-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Import Attributes and RegExp Modifiers #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for another approval before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any changes to eslint-scope
needed?
If not, can you just add a few tests to confirm? For example:
const type = "json";
import pkg from "./package.json" with { type: "json" }; // not a reference to `type`
export * from "./package.json" with { type: "json" }; // not a reference to `type`
export { default } from "./package.json" with { type: "json" }; // not a reference to `type`
import("./package.json", { with: { type } }); // a reference to `type`
Thank you for the review! |
I added test cases to eslint-scope. |
Yeah, I double-checked the code.
For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
Add support for ES2025 import attributes, and add support for RegExp modifiers.
What changes did you make? (Give an overview)
This PR adds support for ES2025 import attributes and RegExp modifiers.
Related Issues
Related to eslint/eslint#19014, eslint/eslint#19073
Is there anything you'd like reviewers to focus on?