Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESLint 8.x #194

Closed
MichaelDeBoey opened this issue Oct 10, 2021 · 5 comments · Fixed by #195
Closed

Support ESLint 8.x #194

MichaelDeBoey opened this issue Oct 10, 2021 · 5 comments · Fixed by #195
Labels
accepted chore

Comments

@MichaelDeBoey
Copy link
Contributor

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂
This was referenced Oct 10, 2021
Merged
Closed
@nzakas
Copy link
Member

nzakas commented Oct 12, 2021

Can you give us some more context? Is something not working with ESLint v8.0.0 right now?

@MichaelDeBoey
Copy link
Contributor Author

@nzakas I've added #195 to update the plugin

@MichaelDeBoey MichaelDeBoey changed the title Support ESLint 8.x Chore(CI): add tests for ESLint 8 Oct 13, 2021
@MichaelDeBoey MichaelDeBoey changed the title Chore(CI): add tests for ESLint 8 Support ESLint 8.x Oct 13, 2021
@nzakas
Copy link
Member

nzakas commented Oct 14, 2021

Thanks. Im still interested to hear if you’ve run into any issues. :)

@MichaelDeBoey
Copy link
Contributor Author

@nzakas Currently it seems to not have any problems with v8 and it's just updating the tests to make sure we test against v8.

@nzakas
Copy link
Member

nzakas commented Oct 15, 2021

Thanks. Marking as a chore.

@ericberens ericberens mentioned this issue Apr 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted chore
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add tests for ESLint 8 MichaelDeBoey/eslint-plugin-markdown
2 participants
@nzakas @MichaelDeBoey