Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for ESLint 8 #195

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@MichaelDeBoey MichaelDeBoey changed the title feat: support ESLint 8.x Update: support ESLint 8.x Oct 10, 2021
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 13, 2021
@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@MichaelDeBoey MichaelDeBoey changed the title Update: support ESLint 8.x Chore(CI): add tests for ESLint 8 Oct 13, 2021
@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@MichaelDeBoey MichaelDeBoey changed the title Chore(CI): add tests for ESLint 8 Chore: add tests for ESLint 8 Oct 13, 2021
@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

@MichaelDeBoey MichaelDeBoey changed the title Chore: add tests for ESLint 8 chore: add tests for ESLint 8 Oct 27, 2021
@btmills
Copy link
Member

btmills commented Oct 31, 2021

Wow, thanks! There are a lot of good improvements in here. While we wait for any remaining dev dependencies to be ready for ESLint 8, would you mind splitting out some smaller changes that can be merged right away? Some ideas for sub-PRs:

  • Add the matrix build for ESLint v6 and v7 in CI.
  • Upgrade the local dev dependencies to ESLint v7 (and auto-fixing .eslintrc.js with the eslint-config-eslint upgrade).
  • Test with the ESLint class API in v7.

@btmills
Copy link
Member

btmills commented Nov 30, 2021

Thank you for splitting those out so we could merge as much as possible already. Where does that leave this PR now? Are we just waiting for dependencies to be updated so we can add v8 to the matrix build?

@MichaelDeBoey
Copy link
Contributor Author

@btmills This can be merged as is, as all tests are green for ESLint 8

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's good to see the tests explicitly confirming this all works across 6, 7, and 8. Thanks for making this happen!

@btmills btmills merged commit 2fd5b89 into eslint:main Nov 30, 2021
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch November 30, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
2 participants