Skip to content

Commit

Permalink
Rephrases: aladdin-add
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaKGoldberg committed Aug 20, 2024
1 parent f15fcda commit cc46547
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions designs/2024-report-unused-inline-configs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Each inline config comment will be compared against the existing configuration v
- If the config comment also specifies rule options, they will be compared for deep equality to the existing rule options

This RFC should wait to begin work until after [feat: add meta.defaultOptions](https://github.com/eslint/eslint/pull/17656) is merged into ESLint.
That way, a rule's `meta.defaultOptions` can be factored into computing whether an inline config's rule options differ from the previously configured options.
That way, if a rule defines `meta.defaultOptions`, those default options can be factored into computing whether an inline config's rule options differ from the previously configured options.

### Default Values

Expand Down Expand Up @@ -223,7 +223,7 @@ Reporting on unused disable directives could be thought of as a subset of report

An additional direction this RFC could propose would be to have the new unused inline config reporting act as a superset of unused disable directive reporting.

However, deprecating `reportUnusedDisableDirectives` would be a disruptive breaking change.
However, deprecating `reportUnusedDisableDirectives` would be a disruptive change and eventual disruptive breaking change.
This RFC prefers keeping away from larger changes like that.
A future change in a subsequent major version could take that on separately.

Expand Down

0 comments on commit cc46547

Please sign in to comment.