Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add board support for Nologo ESP32S3 Pico #9181

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add board support for Nologo ESP32S3 Pico #9181

merged 1 commit into from
Jan 31, 2024

Conversation

imyelo
Copy link
Contributor

@imyelo imyelo commented Jan 27, 2024

Description of Change

Add board support for Nologo ESP32S3 Pico

Tests scenarios

I have tested my pr on this board. Verified by compiling and uploading using PlatformIO, cherry-picking the changes onto the v2.0.11 branch.

Related links

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello imyelo, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 573910d

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imyelo PTAL on my comments.

@imyelo imyelo force-pushed the boards/nologo_esp32s3_pico branch from 5913035 to cc476b9 Compare January 29, 2024 07:09
@imyelo imyelo requested a review from P-R-O-C-H-Y January 29, 2024 07:11
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @imyelo

imyelo added a commit to imyelo/platform-espressif32 that referenced this pull request Jan 29, 2024
@imyelo
Add board Nologo ESP32S3 Pico
7bd2d20 
refs:
- https://www.nologo.tech/product/esp32/esp32s3Pico/esp32S3Pico.html
- espressif/arduino-esp32#9181
@imyelo imyelo mentioned this pull request Jan 29, 2024
Open
@P-R-O-C-H-Y
Copy link
Member

@imyelo You have added a json file, which should not exist in our repository. Please remove it and add the I2C and SPI pins. Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Jan 30, 2024
@imyelo imyelo force-pushed the boards/nologo_esp32s3_pico branch from cc476b9 to bc283a8 Compare January 30, 2024 09:06
@imyelo
Copy link
Contributor Author

imyelo commented Jan 30, 2024 •
edited
Loading

@imyelo You have added a json file, which should not exist in our repository. Please remove it and add the I2C and SPI pins. Thanks

Thanks for your review. Pins added, but I didn't find the json file mentioned. do you mean the reference in the commit from another pr to platformio, or I'm missing something 😄

@imyelo imyelo requested a review from P-R-O-C-H-Y January 30, 2024 09:44
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Jan 30, 2024
@P-R-O-C-H-Y
Copy link
Member

Looks good now :) and I am 100% sure I saw the platformio json file in this PR before 😄.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Jan 30, 2024
@me-no-dev
Copy link
Member

please fix the conflicts :)

@imyelo imyelo force-pushed the boards/nologo_esp32s3_pico branch from bc283a8 to 573910d Compare January 31, 2024 13:14
@imyelo
Copy link
Contributor Author

imyelo commented Jan 31, 2024

please fix the conflicts :)

👌 Fixed.

@me-no-dev me-no-dev merged commit 83e2612 into espressif:master Jan 31, 2024
39 checks passed
@imyelo imyelo deleted the boards/nologo_esp32s3_pico branch January 31, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@imyelo @P-R-O-C-H-Y @me-no-dev @VojtechBartoska