fix(network_provisioning): Consider WIFI_REMOTE for provisioning (IEC-260) #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
- In cases, such as ESP32-P4, we do not have native Wi-Fi and it uses other mechanisms., such as esp-hosted. esp-wifi-remote is used in this case. - Provisioning component currently check if Wi-Fi is natively enabled for it to compile wifi_provisioning sources. This causes link errors when enabling the provisiong for ESP32-P4 - Extend the check for Wi-Fi remote as well, so the sources are compiled
vikramdattu
force-pushed
the
support/network_prov_with_wifi_remote
branch
from
dd98dad to
a82202f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mechanisms., such as esp-hosted. esp-wifi-remote is used in this case.
enabled for it to compile wifi_provisioning sources.
This causes link errors when enabling the provisiong for ESP32-P4
Checklist
urlfield definedChange description
This change extends the provisioning support for the devices(such as P4+C6 setup using esp_hosted for connectivity) using Wi-Fi remotes.