allow naked binaryOp at the start of a selector within :has() #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Richard Silverton <[email protected]>
|
@michaelficarra please could you have a look at this? |
michaelficarra
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Sorry for the delay. This looks great! Thanks for the contribution, @c-harding.
michaelficarra
changed the title
lukaw3d
reviewed
Aug 3, 2024
| const deepChildMatches = esquery(conditional, 'IfStatement:has(> Identifier[name="x"])'); | ||
| assert.equal(0, deepChildMatches.length); | ||
|
|
||
| const shallowChildMatches = esquery(conditional, 'IfStatement:has(> LogicalExpression.test, > Identifier[name="x"])'); |
There was a problem hiding this comment.
hey I tried to use a more complex version of this:
it('fails repeated and nested', function () {
const matches = esquery(
esprima.parse(`
if (x) foo; // Target
if (x) { foo; }
if (y) { foo; }
if (x) bar;
`),
'IfStatement:has(>Identifier[name="x"]):has(>ExpressionStatement>Identifier[name="foo"])'
);
assert.equal(1, matches.length);
});and it doesn't work. Any ideas why, in case this is still fresh on your mind? I found this as a workaround in the mean time:
it('workaround', function () {
const matches = esquery(
esprima.parse(`
if (x) foo; // Target
if (x) { foo; }
if (y) { foo; }
if (x) bar;
`),
'IfStatement:has(>Identifier[name="x"]):has(>ExpressionStatement:has(>Identifier[name="foo"]))'
);
assert.equal(1, matches.length);
});and extracted a simpler to reproduce test case into #146
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
An attempt to fix the complex queries #148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #133, rebased and updated to handle @michaelficarra’s PR feedback
Fixes #132