Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test resources to jfrog #243

Closed
wants to merge 1 commit into from
Closed

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Nov 11, 2024

No description provided.

@ekouts ekouts requested review from jgphpc and teojgo November 11, 2024 07:54
@ekouts ekouts self-assigned this Nov 11, 2024
@@ -9,12 +9,21 @@
import reframe.utility.sanity as sn


class fetch_lampps_resources(rfm.RunOnlyRegressionTest):
executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz'
jfrog = 'https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests'
executable = f'wget {jfrog}/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz'
  • maybe jfrog should be set in the config file(s) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's that useful because we have many tests pulling from jfrog in different directories. Do you think we will need to move them to a different directory eventually?

@@ -9,6 +9,14 @@
import reframe.utility.sanity as sn


class fetch_namd_resources(rfm.RunOnlyRegressionTest):
executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/NAMD.tar.gz && tar -xvf LAMMPS.tar.gz'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-todi-cpe

Copy link
Collaborator

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekouts do you think we should make the jfrog repo more general in the configuration or as a utility?

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-todi-cpe

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

@ekouts do you think we should make the jfrog repo more general in the configuration or as a utility?

I would leave it as it is, but if you both agree, then I can change it.
There are different ways to do it. We could use the resourcesdir, with the understanding that it is not a directory, but a url. Or we add it in the extras of all partitions. I thought also about creating a simple mixing with standard variables for cscs but then we have to update many tests and I am not sure it's worth it.

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-todi-cpe

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-eiger-cpe

2 similar comments
@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-eiger-cpe

@ekouts
Copy link
Collaborator Author

ekouts commented Nov 27, 2024

cscs-ci run alps-eiger-cpe

@ekouts ekouts closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants