Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(monorepo): remove superchain-registry dep and require pnpm 9 #274

Merged

Conversation

jakim929
Copy link
Contributor

@jakim929 jakim929 commented Apr 17, 2024

builds were failing post pnpm 9 upgrade because of some change in how github repo packages are fetched. removed the package since we don't use it right now.

to prevent inconsistencies happening with the new pnpm lockfile v9, also require that devs use pnpm 9

  1. force devs to use pnpm 9 - see "engine"
  2. force corepack to use pnpm 9 - see "packageManager"
  3. remove superchain registry dep

Copy link

cloudflare-workers-and-pages bot commented Apr 17, 2024

Deploying superchain-paymaster-nft-mint-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49da260
Status: ✅  Deploy successful!
Preview URL: https://7a0b4cb3.superchain-paymaster-nft-mint-example.pages.dev
Branch Preview URL: https://04-17-build-monorepo-specify.superchain-paymaster-nft-mint-example.pages.dev

View logs

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for storybook-component-library canceled.

Name Link
🔨 Latest commit 49da260
🔍 Latest deploy log https://app.netlify.com/sites/storybook-component-library/deploys/66202321424bb200085e69cf

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for op-dapp-console-preview ready!

Name Link
🔨 Latest commit 49da260
🔍 Latest deploy log https://app.netlify.com/sites/op-dapp-console-preview/deploys/66202321336850000866e157
😎 Deploy Preview https://deploy-preview-274--op-dapp-console-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jakim929
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jakim929 and the rest of your teammates on Graphite Graphite

@jakim929 jakim929 changed the title build(monorepo): specify pnpm version to fix build build(monorepo): remove superchain-registry dep Apr 17, 2024
@jakim929 jakim929 force-pushed the 04-17-build_monorepo_specify_pnpm_version_to_fix_build branch from cb4828e to 9e601ec Compare April 17, 2024 19:27
@jakim929 jakim929 force-pushed the 04-17-build_monorepo_specify_pnpm_version_to_fix_build branch from 9e601ec to 49da260 Compare April 17, 2024 19:29
@jakim929 jakim929 marked this pull request as ready for review April 17, 2024 19:32
@jakim929 jakim929 requested a review from a team as a code owner April 17, 2024 19:32
@jakim929 jakim929 requested a review from tarunkhasnavis April 17, 2024 19:32
@jakim929 jakim929 changed the title build(monorepo): remove superchain-registry dep build(monorepo): remove superchain-registry dep and require pnpm 9 Apr 17, 2024
@jakim929 jakim929 merged commit 69eff5a into main Apr 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants