Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EIP-7732] ExecutionPayloadEnvelopesByRange RPC #4120

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[EIP-7732] ExecutionPayloadEnvelopesByRange RPC #4120

wants to merge 5 commits into from
+45 −9

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Feb 5, 2025

  • fixes versioning of existing RPC (no need to bump versions)
  • adds ExecutionPayloadEnvelopesByRange
  • assumes slot to be present in ExecutionPayloadEnvelope

potuz
potuz reviewed Feb 9, 2025
View reviewed changes
Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I think we may want to consider the option of getting these payloads blind. When range syncing an unfinalized long chain, the EL will have the option to download blocks from a given hash on the EL p2p chain, while the CL will still need the envelope to sync the CL state. I envision that this decoupling of blocks with payloads will actually be useful in the future for long range syncing.

specs/_features/eip7732/p2p-interface.md Outdated Show resolved Hide resolved
@tbenr
Copy link
Contributor Author

tbenr commented Feb 12, 2025

the EL will have the option to download blocks from a given hash on the EL p2p chain, while the CL will still need the envelope to sync the CL state.

I see. In that mode we will be always optimistically syncing, from CL perspective.

jtraglia
jtraglia approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tbenr! @potuz this is ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz left review comments

@Ssaaddaamm Ssaaddaamm Ssaaddaamm left review comments

@jtraglia jtraglia jtraglia approved these changes

@datis56 datis56 datis56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbenr @potuz @jtraglia @Ssaaddaamm @datis56