fix: stewardship retrieving the same chunk multiple times #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacevicljubisa
approved these changes
Feb 10, 2025
istae
approved these changes
Feb 11, 2025
martinconic
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Stewardship of
/byteuploads was repeatedly retrieving the root chunk because it first attempts to load a manifest, which the upload is not.To address this, we now iterate over manifest addresses only if the input reference is "likely" a manifest reference i.e The root chunk span is small (less than swarm.ChunkSize)
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#4977
Screenshots (if appropriate):