Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation spec #81

Merged
merged 1 commit into from
Jul 18, 2013
Merged

Calculation spec #81

merged 1 commit into from
Jul 18, 2013

Conversation

thegcat
Copy link
Contributor

@thegcat thegcat commented Jul 18, 2013

Add a spec for the somewhat convoluted calculations of open spots.

Also see #77

@thegcat
Copy link
Contributor Author

thegcat commented Jul 18, 2013

I've never worked with draper an I'm a little unsure what methods should be public or not in a decorator, feel free to adapt as needed.

@pietia
Copy link
Contributor

pietia commented Jul 18, 2013

Thanks. I will take care of Travis later on today. BTW, There might be some specs failing due to this #80 issue (basically - adding validations in Authentication leads to circular dependency which makes this https://github.com/eurucamp/eurucamp-activities-2013/blob/master/app/controllers/authentications_controller.rb#L24 code fail (btw2, that's the code 'borrowed' from our c4p app that we got from wroc_love.rb organizers) )

@thegcat
Copy link
Contributor Author

thegcat commented Jul 18, 2013

I've updated the commit and made the method public and I've given it a better name.

@ghost ghost assigned pietia Jul 18, 2013
pietia added a commit that referenced this pull request Jul 18, 2013
@pietia pietia merged commit 5ebbccb into eurucamp:master Jul 18, 2013
myabc pushed a commit that referenced this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants