ev3dev: replace opaque attribute accessor errors #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
commented
Oct 2, 2016
| @@ -683,14 +683,14 @@ func stateFrom(data, _ string, err error) (MotorState, error) { | |||
| for _, s := range strings.Split(data, " ") { | |||
| bit, ok := motorStateTable[s] | |||
| if !ok { | |||
| return 0, fmt.Errorf("ev3dev: unrecognized motor state value: %s in [%s]", s, data) | |||
| return 0, newInvalidValueError(d, state, "unrecognized motor state", s, motorStates) | |||
There was a problem hiding this comment.
This should probably do something like keys(motorStateTable) in place of motorStates where
func keys(states map[string]MotorState) []string {
l := make([]string, 0, len(states))
for k := range states {
l = append(l, k)
}
sort.Strings(l)
return l
}
because with the current API, it is possible for the user to mutate the motorStates slice.
kortschak
force-pushed
the
errors
branch
2 times, most recently
from
7ef36a9 to
dc3b60e
Compare
|
LGTM |
vladimir-ch
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design is not finalised, but this makes future changes easier. Methods and types will be exported as necessary.
Updates #24.
@vladimir-ch Please take a look.