DOCS: clarify meaning of merge_streams option (#664) #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforbes
changed the title
maximlt
approved these changes
Feb 9, 2025
bsipocz
approved these changes
Feb 11, 2025
|
Thank you @mforbes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make a minor documentation adjustment to inform that the
merge_streamsconfiguration option separately mergesstdoutandstderr, resolving issue #664. The previous wording, while technically correct, seemed to imply thatstdoutandstderrstreams will be merged together.Note: There are some testing issues, and code formatting issues with
blackandruffthat I did not fix to keep this PR minimal. Let me know if you would like me to include those (at least the formatting issues).