Skip to content

Commit

Permalink
Test with Elixir 1.12 and OTP 24.0 (exercism#739)
Browse files Browse the repository at this point in the history
  • Loading branch information
angelikatyborska authored May 21, 2021
1 parent 7f84a77 commit afc4b07
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 25 deletions.
23 changes: 11 additions & 12 deletions .dialyzer_ignore.exs
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
[
{":0:unknown_function Function RPG.Edible.Atom.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.BitString.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Float.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Function.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Integer.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.List.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Map.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.PID.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Port.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Reference.__impl__/1 does not exist."},
{":0:unknown_function Function RPG.Edible.Tuple.__impl__/1 does not exist."}

~r|Function RPG\.Edible\.Atom\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.BitString\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Float\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Function\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Integer\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.List\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Map\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.PID\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Port\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Reference\.__impl__/1 does not exist\.|,
~r|Function RPG\.Edible\.Tuple\.__impl__/1 does not exist\.|
# # {short_description}
# {":0:unknown_function Function :erl_types.t_is_opaque/1/1 does not exist."},
# # {short_description, warning_type}
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
elixir: [1.11]
otp: [23.2]
elixir: [1.12]
otp: [24.0]

steps:
- name: Checkout code
Expand Down Expand Up @@ -77,6 +77,8 @@ jobs:
otp: '22.2'
- elixir: '1.11.0'
otp: '23.2'
- elixir: '1.12.0'
otp: '24.0'

steps:
- uses: actions/[email protected]
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr.ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
elixir: [1.11]
otp: [23.2]
elixir: [1.12]
otp: [24.0]

steps:
- name: Checkout PR
Expand Down Expand Up @@ -74,6 +74,8 @@ jobs:
otp: '22.2'
- elixir: '1.11.0'
otp: '23.2'
- elixir: '1.12.0'
otp: '24.0'

steps:
- uses: actions/[email protected]
Expand Down
4 changes: 1 addition & 3 deletions exercises/concept/city-office/test/form_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ defmodule FormTest do
{:"::", _, [_, type_definition]} = Code.Typespec.type_to_quoted(type)

assert type,
"expected the module#{unquote(module_name)} to have a public type named #{
unquote(type_name)
}"
"expected the module#{unquote(module_name)} to have a public type named #{unquote(type_name)}"

actual_type_definition = Macro.to_string(type_definition)
assert actual_type_definition == unquote(expected_type_definition)
Expand Down
4 changes: 1 addition & 3 deletions exercises/practice/beer-song/.meta/example.ex
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ defmodule BeerSong do
end

def verse(number) do
"#{number} bottles of beer on the wall, #{number} bottles of beer.\nTake one down and pass it around, #{
number - 1
} bottles of beer on the wall.\n"
"#{number} bottles of beer on the wall, #{number} bottles of beer.\nTake one down and pass it around, #{number - 1} bottles of beer on the wall.\n"
end

def lyrics(range \\ 99..0) do
Expand Down
4 changes: 1 addition & 3 deletions exercises/practice/twelve-days/.meta/example.ex
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ defmodule TwelveDays do
"""
@spec verse(number :: integer) :: String.t()
def verse(number) do
"On the #{ordinal(number)} day of Christmas my true love gave to me: #{
gifts_for_day(number, [])
}."
"On the #{ordinal(number)} day of Christmas my true love gave to me: #{gifts_for_day(number, [])}."
end

defp gifts_for_day(1, []), do: gift(1)
Expand Down

0 comments on commit afc4b07

Please sign in to comment.