Get rid of the workspace.Locate behavior and comms package #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 5, 2018 09:51
This no longer accepts just an exercise name. It mirrors the behavior of the submit command where you pass the path to the exercise you want to open in the browser. In the future we can expand this to take --exercise, --track, and --team.
We determine the exact exercise directory based on the filepaths. Since we have the directory, we don't need to do complicated guessing, we can just load in the exercise metadata directly.
We were overloading the variable, which makes it confusing.
We're going to want to ensure that the directory exists. For the moment, this directory is the same as the exercise directory, but we're working towards putting this in a subdirectory to match common industry conventions.
We've moved the idea of the exercise metadata path onto the Exercise type.
It's no longer used.
kytrinyx
changed the title
nywilken
reviewed
Aug 7, 2018
cmd/download.go
Outdated
| return errors.New("need an --exercise name or a solution --uuid") | ||
| } | ||
|
|
||
| var slug string | ||
| var param string |
There was a problem hiding this comment.
What is param supposed to represent an exercise iteration?
There was a problem hiding this comment.
param is the param to the URL that we're calling on the API. It's either the string latest, or an actual UUID.
nywilken
reviewed
Aug 7, 2018
cmd/download.go
Outdated
| return errors.New("need an --exercise name or a solution --uuid") | ||
| } | ||
|
|
||
| var slug string | ||
| var param string | ||
| if uuid == "" { |
There was a problem hiding this comment.
Yon can simplify this a bit
param := "latest"
if uuid != "" {
param = uuid
}
There was a problem hiding this comment.
Thanks! Yeah, that's much better. Updated.
Simplify a conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is big in the sense that it deletes a lot of code, but the core of the PR is three small simplifications:
Once all of those were simplified, we no longer used
SolutionPath,IsSolutionPath,ResolveSolutionPath, orLocate, and could delete all of the functions and their associated tests. And the entirecommspackage!This removes the behavior of adding a numeric suffix when downloading an exercise if the exercise already exists, which is the first step in fixing #661
The second step is to make the download command more robust so it doesn't clobber existing solution files: #697