-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump wazero version #64
Conversation
we released v1.7.2 a few days ago with a bunch of fixes https://github.com/tetratelabs/wazero/releases/tag/v1.7.2 |
This release may also see some improvements Will test it out |
Looks like we're using a now-removed API (1.7.0 -> 1.7.3):
|
|
There do seem to be some improvements despite there being some regressions, I think I'm in favor of updating to 1.7.3 since it probably includes some other bugfixes and improvements compared to 1.3.0 |
I am too! I think we just need to consider what the alternative is for the experimental Listener things are which were removed. We have tests to ensure we can still call these APIs, and I think we use them in the Observe Go SDK, so there's some additional work to figure out where they went and/or how to fix/update the code. |
It looks like we can just switch over to experimental.WithFunctionListenerFactory - I will try to update the test |
@zshipko i can't approve, given it's my PR - but if CI passes, feel free to merge! we can do some additional testing before we release. |
Opening this up as a draft for now for discussion.
This PR brings
wazero
up to the latest version, which introduces their new optimizing compiler. I've added benchmarks from the current version we usev1.3.0
, and the latestv1.7.0
:v1.3.0
:v1.7.0
: