Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extism.Pool #65

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions pool.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
package extism

import (
"context"
"errors"
"time"

"sync"
)

type PluginFunc = func(ctx context.Context) (*Plugin, error)

type pluginInstance struct {
lock sync.Mutex
Plugin *Plugin
}

func (p *pluginInstance) Done() {
p.lock.Unlock()
}

type Pool struct {
maxInstances int
plugins map[string]PluginFunc
instances map[string][]*pluginInstance
lock sync.Mutex
}

func NewPool(maxInstances int) *Pool {
return &Pool{
maxInstances: maxInstances,
plugins: map[string]PluginFunc{},
instances: map[string][]*pluginInstance{},
}
}

func (pool *Pool) Add(key string, f PluginFunc) {
pool.lock.Lock()
defer pool.lock.Unlock()
pool.plugins[key] = f
pool.instances[key] = []*pluginInstance{}
}

func (pool *Pool) Count(key string) int {
pool.lock.Lock()
defer pool.lock.Unlock()
x, ok := pool.instances[key]
if !ok {
return 0
}

return len(x)
}

func (pool *Pool) findAvailable(key string) *pluginInstance {
for _, p := range pool.instances[key] {
if p.lock.TryLock() {
return p
}
}

return nil
}

func (pool *Pool) Get(ctx context.Context, key string, timeout time.Duration) (*pluginInstance, error) {
end := time.After(timeout)
pool.lock.Lock()
defer pool.lock.Unlock()

if p := pool.findAvailable(key); p != nil {
return p, nil
}

if len(pool.instances[key]) < pool.maxInstances {
f := pool.plugins[key]
plugin, err := f(ctx)
if err != nil {
return nil, err
}
instance := &pluginInstance{Plugin: plugin}
instance.lock.Lock()
pool.instances[key] = append(pool.instances[key], instance)
return instance, err
}

for {
select {
case <-end:
return nil, errors.New("Timed out getting instance for key: " + key)
default:
p := pool.findAvailable(key)
if p != nil {
return p, nil
}
}
}
}

func (pool *Pool) WithPlugin(ctx context.Context, key string, timeout time.Duration, f func(*Plugin) error) error {
p, err := pool.Get(ctx, key, timeout)
if err != nil {
return err
}
defer p.Done()
return f(p.Plugin)
}
50 changes: 50 additions & 0 deletions pool_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package extism

import (
"context"
"log"
"sync"
"testing"
"time"
)

func runTest(wg *sync.WaitGroup, pool *Pool, n int) {
defer wg.Done()
time.Sleep(time.Millisecond * time.Duration(n))
var data string
pool.WithPlugin(context.Background(), "test", time.Second, func(plugin *Plugin) error {
_, x, err := plugin.Call("count_vowels", []byte("aaa"))
data = string(x)
return err
})
log.Println(string(data))
}

func TestPluginPool(t *testing.T) {
pool := NewPool(2)
manifest := Manifest{
Wasm: []Wasm{
WasmFile{
Path: "../code.wasm",
},
},
}

pool.Add("test", func(ctx context.Context) (*Plugin, error) {
return NewPlugin(ctx, manifest, PluginConfig{}, []HostFunction{})
})

wg := &sync.WaitGroup{}
wg.Add(10)
go runTest(wg, pool, 1000)
go runTest(wg, pool, 1000)
go runTest(wg, pool, 1000)
go runTest(wg, pool, 1000)
go runTest(wg, pool, 1000)
go runTest(wg, pool, 500)
go runTest(wg, pool, 500)
go runTest(wg, pool, 500)
go runTest(wg, pool, 500)
go runTest(wg, pool, 500)
wg.Wait()
}
Loading